Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenerateDocs becomes independent of Data #270

Merged
merged 1 commit into from May 18, 2022

Conversation

navinrathore
Copy link
Contributor

Separated Model Documenter and Data Documenter
StopWords Becomes part of Data Documenter
Got rid of fixed list of 'z' columns

Refer to bug #263

Separeted MOdel Documenter and Data Documenter
StopWords Becomes part of Data Documenter
Got rid of fixed list of 'z' columns
@navinrathore
Copy link
Contributor Author

Largely, all things have been incorporated and tested, that came in our discussion. Still, following points need attention.

  • Column/Data Document - parent doc Link (parent Name) is hard coded (Top right corner on page). Need to know root location ($ZINGG_HOME)
  • Decision on Column documents generated from modelDocumenter and DataDocumenter differentiation and their location of storage. As of now, both have same name and location. first ones are overwritten by stop words one. Original ones do not have any information yet. Though, all links work fine.
  • Data documentation - list of schema field formation, table beautification
  • Column/Data documentation - additional data on the page, if any

@navinrathore navinrathore marked this pull request as ready for review May 18, 2022 05:15
@sonalgoyal sonalgoyal merged commit 61c9bc7 into zinggAI:main May 18, 2022
@navinrathore navinrathore deleted the generateDocs263 branch June 1, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants