Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API chnages issue part 2,4,5 #326

Merged
merged 2 commits into from Jun 14, 2022
Merged

API chnages issue part 2,4,5 #326

merged 2 commits into from Jun 14, 2022

Conversation

RavirajBaraiya
Copy link
Contributor

No description provided.

sonalgoyal
sonalgoyal requested changes Jun 13, 2022
View reviewed changes
Copy link
Member

@sonalgoyal sonalgoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep all flavours of unit and execute, the wrapper method initandexec will be used in most cases, but in some cases we will not use it and use the atomic unit and execute

also did not understand the changes to febrl example

@sonalgoyal sonalgoyal merged commit 484abc0 into zinggAI:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonalgoyal sonalgoyal sonalgoyal requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RavirajBaraiya @sonalgoyal