New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obvious dupes performance optimisation #628

Merged

sonalgoyal merged 4 commits into zinggAI:0.4.0 from zinggAI:obviousDupes

Jul 31, 2023

Collaborator

vikasgupta78 commented Jul 31, 2023

Obvious dupes performance optimisation

vikasgupta78 added 3 commits

July 31, 2023 11:07


          removing commented code in execute to improve readability

59a14b9


          optimising the obv dupes to use only ids for pairs

8a77f40


          select only required cols for graph

b64cf9c

sonalgoyal requested changes

View reviewed changes

Member

sonalgoyal left a comment

looks good to me but it will be great if you can bring back the commented code - its used for quick debugs when things are going wrong,


          adding back commented code

9dba2c9

sonalgoyal merged commit 8430d42 into zinggAI:0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment