Make sphinx works #806
Merged
Make sphinx works #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A temporary solution, based on the following: - introducing a new env variable ZINGG_DRY_RUN - if the variable is set: + mimic globally used JVM-stuff + otherwise do nothing ++ slightly update ignore and docs/Makefile ++ apply formatting to client.py On branch 762-fix_sphinx_build Changes to be committed: modified: .gitignore modified: python/docs/Makefile new file: python/pyproject.toml modified: python/zingg/client.py
|
@sonalgoyal make a look, please! This changes is a working workaround only. We slightly discussed this topic in slack, that python API should be refactored anyway (due SPARK-CONNECT), so I would suggest to replace such a trick by a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A temporary solution, based on the following:
++ slightly update ignore and docs/Makefile
++ apply formatting to client.py
BECAUSE OF FORMATTING THE CODE:
getJVMwas changed, other changes related to format only!On branch 762-fix_sphinx_build
Changes to be committed:
modified: .gitignore
modified: python/docs/Makefile
new file: python/pyproject.toml
modified: python/zingg/client.py
Close #762