Validate addresses with zingolib command parse
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zancas
reviewed
Apr 7, 2023
zancas
reviewed
Apr 7, 2023
zancas
reviewed
Apr 7, 2023
There was a problem hiding this comment.
Looks good so far. Is it ready to merge? Who should merge it (when it is) @james-katz ? @fluidvanadium ?
No yet, I want to take a deep look because maybe I have to adjust more things... |
Closed
juanky201271
force-pushed
the
dev_zingolib_parse_all_addresses
branch
from
c0a64e5
to
6d330dc
Compare
|
This PR is ready for merging... @zancas |
|
I'm sorry but I need to work on top of this, I can't wait for 3 weeks or so until this will be review... this is tested & working, you can test it anytime... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finished.