Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Infrastructure Upgrade, port lib-to-node tests to lib-to-darkside #816

Open
zancas opened this issue Feb 23, 2024 · 0 comments
Open

Comments

@zancas
Copy link
Member

zancas commented Feb 23, 2024

Setup

Ordered Set of Tasks:

Ensure that you can run these tests:

  1. https://github.com/zingolabs/zingolib/blob/dev/integration-tests/tests/integrations.rs

  2. https://github.com/zingolabs/zingolib/tree/dev/darkside-tests/tests

  3. Rename this directory https://github.com/zingolabs/zingolib/tree/dev/integration-tests
    TO: "lib-to-node-tests"

  4. Rename this directory https://github.com/zingolabs/zingolib/tree/dev/darkside-tests
    TO: "lib-to-darkside-tests"

Create darkside-parity-tests

Start with the test that you understand best. Best Understood Test (BUT)

For each test in the "lib-to-node-tests":

  1. create a new test in "lib-to-darkside" with the same name
  2. make the new test in "lib-to-darkside" validate all of the same behavior as the original test, it should make the same assertions in the same order. If the original test should have more assertions, then add them!

This issue is complete when every test in lib-to-node has a darkside-parity test that performs the same lightclient-behavior-validation as the original test.

There should be (at least initially), a single PR for each test that is ported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant