Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#451] Detach --regtest from local zcashd environment setup #452

Closed
wants to merge 2 commits into from

Conversation

pacu
Copy link
Collaborator

@pacu pacu commented Aug 27, 2023

This breaks the darksidewalletd tests on regtest since RegtestManager kicks in when the --regtest flag is specified.

In order to be able to point to a lightwalletd server in --darkside-very-insecure mode this has to be modified so callers can tell Zingolib that they won't be needing the RegtestManager at all.

closes #451

This breaks the darksidewalletd tests on regtest since RegtestManager
kicks in when the --regtest flag is specified.

In order to be able to point to a lightwalletd server in
--darkside-very-insecure mode this has to be modified so callers
can tell Zingolib that they won't be needing the RegtestManager at all.

closes zingolabs#451
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (587d485) 60.20% compared to head (874e58d) 60.20%.
Report is 2 commits behind head on dev.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #452   +/-   ##
=======================================
  Coverage   60.20%   60.20%           
=======================================
  Files          33       33           
  Lines        5375     5375           
=======================================
  Hits         3236     3236           
  Misses       2139     2139           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AloeareV
Copy link
Contributor

AloeareV commented Sep 7, 2023

I don't think this is necessary. The --regtest flag is a convenience for the specific scenario of zingo managing all of the binaries for you, but since the darkside tests don't want that, I think --chain regtest will do what you want here: connect to a regtest server but otherwise act like normal zingo.

@AloeareV
Copy link
Contributor

@pacu let me know if you still need this, and I'll merge it

@AloeareV AloeareV closed this Sep 22, 2023
@pacu
Copy link
Collaborator Author

pacu commented Oct 4, 2023

@AloeareV can you reopen this? I've updated it to the latest dev, don't merge because I need to test it again with the new code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detach --regtest from local zcashd environment setup
3 participants