Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes arot changes outbund tx height #713

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

pacu
Copy link
Collaborator

@pacu pacu commented Nov 23, 2023

[#620] Advanced ReOrg Test changes outgoing tx height

Closes #620
A Re Org occurs and changes the height of an outbound transaction

Pre-condition: Wallet has funds

Steps:

  1. create fake chain
    • 1a. sync to latest height
  2. send transaction to recipient address
  3. getIncomingTransaction
  4. stage transaction at sentTxHeight
  5. applyHeight(sentTxHeight)
  6. sync to latest height
    • 6a. verify that there's a pending transaction with a mined height of sentTxHeight
  7. stage 15 blocks from sentTxHeight
  8. a stage sent tx to sentTxHeight + 2
  9. applyHeight(sentTxHeight + 1) to cause a 1 block reorg
  10. sync to latest height
  11. verify that there's a pending transaction with -1 mined height
  12. applyHeight(sentTxHeight + 2)
  • 11a. sync to latest height
  1. verify that there's a pending transaction with a mined height of sentTxHeight + 2
  2. apply height(sentTxHeight + 15)
  3. sync to latest height
  4. verify that there's no pending transaction and that the tx is displayed on the sentTransactions collection
    Build atop of Implement a reorg that removes an incoming transaction #712

zancas
zancas previously approved these changes Nov 23, 2023
Copy link
Member

@zancas zancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test-only change, LGTM!

@pacu pacu dismissed zancas’s stale review November 23, 2023 22:24

The merge-base changed after approval.

Copy link
Member

@zancas zancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merge latest dev. LGTM.

@zancas zancas merged commit 2f770e0 into zingolabs:dev Nov 23, 2023
16 checks passed
@pacu pacu deleted the fixes-arot-changes-outbund-tx-height branch December 4, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a ReOrg Test that changes the height of a sent tx
2 participants