Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

There are (at least) two available forks of lightwalletd #37

Closed
zancas opened this issue May 25, 2022 · 5 comments
Closed

There are (at least) two available forks of lightwalletd #37

zancas opened this issue May 25, 2022 · 5 comments
Assignees

Comments

@zancas
Copy link
Member

zancas commented May 25, 2022

https://github.com/adityapk00/lightwalletd

AND

https://github.com/zcash/lightwalletd

We need to choose one, clearly indicate the choice, and target it exclusively.

@zancas
Copy link
Member Author

zancas commented May 25, 2022

This bug report might provide a criteria for choosing between the alternatives:
adityapk00/zecwallet-lite#156 (comment)

@zancas zancas changed the title There are (at least) two widely used forks of lightwalletd There are (at least) two available forks of lightwalletd May 25, 2022
@AloeareV
Copy link

My instinct is to target upstream, without very convincing benefits to using aditya's. It's yet another large codebase to keep up with maintenance of in a language I don't believe any of us are particularly experienced with, which is in my opinion a very large downside, especially given the scale of what we're already trying to get up to speed with.

@zancas
Copy link
Member Author

zancas commented May 25, 2022

I tentatively agree... but mostly think we need more evidence/data.

@zancas
Copy link
Member Author

zancas commented May 25, 2022

This bugfix seems to argue in favor of the zcash variant:

https://github.com/zcash/lightwalletd/releases/tag/v0.4.11

@dannasessha
Copy link

We've moved to zcash's version, though we are still fiddling with which branch should use which dependency branch or commit.

Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants