forked from OpenMW/openmw
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please ignore #1314
Closed
Closed
Please ignore #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: apps/opencs/view/world/table.cpp apps/opencs/view/world/table.hpp
Conflicts: apps/opencs/CMakeLists.txt
Conflicts: apps/opencs/view/world/tablebottombox.cpp
(cherry picked from commit 13bb6be) Conflicts: apps/opencs/model/doc/savingstages.cpp apps/opencs/model/world/land.cpp apps/opencs/model/world/land.hpp apps/opencs/model/world/landtexture.cpp
(cherry picked from commit 8243fb2) Conflicts: apps/esmtool/record.cpp
(cherry picked from commit 0c6ab6c)
(cherry picked from commit daaff12) Conflicts: apps/openmw/mwworld/store.cpp components/esm/util.hpp
(cherry picked from commit 9a8ca81)
(cherry picked from commit f9b0b7e)
(cherry picked from commit fc8e408)
(cherry picked from commit 9116c70) Conflicts: apps/esmtool/record.cpp
(cherry picked from commit d0d8c2e)
(cherry picked from commit 38c155c)
(cherry picked from commit 771193b)
(cherry picked from commit 1e817a9)
(cherry picked from commit f91aae2)
(cherry picked from commit aae1aa3)
I'm a bit confused; `mwsound/ffmpeg_decoder.hpp/cpp` requires FFMPEG headers to compile, how did this work in the first place? (cherry picked from commit d2a4175)
(cherry picked from commit 0220e82) Conflicts: apps/openmw/CMakeLists.txt
(cherry picked from commit af49235)
Found in some .ess files, not sure what they mean. (cherry picked from commit 0bdfd1b)
…ading/saving (cherry picked from commit e0e9e7f)
(cherry picked from commit b74b274)
(cherry picked from commit 1093a53)
(cherry picked from commit 26640d1)
(cherry picked from commit f5c61ee)
(cherry picked from commit 99500f4)
There is no change in behaviour since we were using the C locale. The locale-aware tolower is much slower than the locale-unaware one. At least on Linux/GCC it calls dynamic_cast's, and is overall slower by an order of magnitude. (cherry picked from commit 27e6692)
Log warning message and show the default texture when encountering invalid ESM::LandTexture references. (cherry picked from commit 35fa1f5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about this, submitted to wrong repo.