-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetchmore, json encoding, and query var change patches #394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b8defe8
to
af89b19
Compare
Codecov Report
@@ Coverage Diff @@
## beta #394 +/- ##
=========================================
- Coverage 58.04% 57.64% -0.4%
=========================================
Files 32 32
Lines 1299 1308 +9
=========================================
Hits 754 754
- Misses 545 554 +9
Continue to review full report at Codecov.
|
🎉 This PR is included in version 2.1.1-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.0.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
closes #389, #386, #374, #351
Fixes / Enhancements
object.toJson()
intoKey()
(Crash serializing json_serializable objects #374)noCache
when callingfetchMore
to avoid cache writes/normalizationwriteToCache
inaddQueryResult
sofetchMore
now calls:onListen
(QueryResult loading not 'true' when changing variables (in QueryOptions) #351 (comment))key
to Query` to reset the stream (initial renders with new variables would have stale data otherwise)