Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetchmore, json encoding, and query var change patches #394

Merged
merged 4 commits into from
Aug 29, 2019

Conversation

micimize
Copy link
Collaborator

@micimize micimize commented Aug 27, 2019

closes #389, #386, #374, #351

Fixes / Enhancements

      queryManager.addQueryResult(
        queryId,
        fetchMoreResult,
        writeToCache: true,
      );

@micimize micimize changed the title Fetchmore patch: don't normalize results, write final result to cache Fetchmore, json encoding, and query var change patches Aug 27, 2019
mainawycliffe
mainawycliffe previously approved these changes Aug 28, 2019
Copy link
Collaborator

@mainawycliffe mainawycliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #394 into beta will decrease coverage by 0.39%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             beta     #394     +/-   ##
=========================================
- Coverage   58.04%   57.64%   -0.4%     
=========================================
  Files          32       32             
  Lines        1299     1308      +9     
=========================================
  Hits          754      754             
- Misses        545      554      +9
Flag Coverage Δ
#graphql_client 58.33% <8.33%> (-0.42%) ⬇️
#graphql_flutter 29.03% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...kages/graphql/lib/src/core/raw_operation_data.dart 94.11% <0%> (-5.89%) ⬇️
...ackages/graphql/lib/src/core/observable_query.dart 6.92% <0%> (-0.28%) ⬇️
packages/graphql/lib/src/core/query_manager.dart 48.3% <25%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 443d5b5...af89b19. Read the comment docs.

@micimize micimize merged commit 883b072 into zino-hofmann:beta Aug 29, 2019
@micimize micimize deleted the fetchmore_patch branch August 29, 2019 21:42
@HofmannZ
Copy link
Member

🎉 This PR is included in version 2.1.1-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@HofmannZ
Copy link
Member

🎉 This PR is included in version 3.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@HofmannZ
Copy link
Member

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants