Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constant and constantString could be in ConfigDescriptors #454

Open
vigoo opened this issue Nov 29, 2020 · 2 comments
Open

constant and constantString could be in ConfigDescriptors #454

vigoo opened this issue Nov 29, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@vigoo
Copy link
Contributor

vigoo commented Nov 29, 2020

This came up in a discussion of vigoo/zio-aws#144 and I wanted to move this topic here.

I believe the DerivationUtils.constant and DerivationUtils.constantString would be useful outside the derivation implementation too, so it could be moved to ConfigDescriptors where the other config descriptor constructors are.

More generally I think the derivation should be just an optional convenience tool and everything it does should be possible to do by the users by hand. Here this is somewhat true because the above mentioned descriptor can be implemented in user code but its not that straightforward as it needs a custom property type.

@afsalthaj
Copy link
Collaborator

Thanks @vigoo for moving the discussion here. Yes constants could be part of ConfigDescriptor. Agreed :)

We will continue working over this feature right after our 1.0 release. And I can see 1.0.1 would have semantics related to “constant” in “ConfigDescriptorModule”.

@afsalthaj
Copy link
Collaborator

Hi @vigoo
I think, as a next step, Description needs to hold the information about type, constants, default separately. As of now its a comma separated string in a List.

This actually goes in line with this ticket. What do you think?

@afsalthaj afsalthaj added the enhancement New feature or request label Dec 1, 2020
@afsalthaj afsalthaj self-assigned this Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants