Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support streaming responses in zio.http.api #1500

Closed
jdegoes opened this issue Sep 18, 2022 · 2 comments
Closed

Support streaming responses in zio.http.api #1500

jdegoes opened this issue Sep 18, 2022 · 2 comments
Labels
enhancement New feature or request ziohackathon An official ticket for ZIO Hackathon

Comments

@jdegoes
Copy link
Member

jdegoes commented Sep 18, 2022

Is your feature request related to a problem? Please describe.

Streaming responses is supported in the api of zio.http.api, but is not supported in the implementation for client and server (APIClient.scala, APIServer.scala, located in /src/main/scala/zio/http/api/internal/).

Describe the solution you'd like

Streaming responses should be supported for both client and server, with accompanying test suites.

Describe alternatives you've considered

N/A

Additional context

See the existing implementation for how a single value is deserialized, and in particular, update both client and server to check the API#output sum type in order to determine whether the response is supposed to be a single value or a stream of elements.

@jdegoes jdegoes added the enhancement New feature or request label Sep 18, 2022
@jdegoes jdegoes added the ziohackathon An official ticket for ZIO Hackathon label Oct 25, 2022
@ithinkicancode
Copy link

I'm going to take a crack at this ticket. Please assign it to me. Thanks.

@jdegoes
Copy link
Member Author

jdegoes commented Apr 18, 2023

Clearing assignees for now.

@jdegoes jdegoes closed this as completed Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ziohackathon An official ticket for ZIO Hackathon
Projects
Development

No branches or pull requests

2 participants