beautifyErrors middleware bug: Defining a 409 Response with a body leads to a java.util.NoSuchElementException: None.get exception

[guizmaii]

Hey 🙂

I have an API defined this way:

val api: HttpApp[Any, Throwable] = ...

and a handler for the errors:

final case class PublicError(title: String, details: Option[String])
object PublicError {
  implicit val encoder: JsonEncoder[PublicError] = DeriveJsonEncoder.gen[PublicError]

  def from(e: DuplicateError): PublicError = ...
}

def toPublicError(e: Throwable): UIO[Response] = 
  e match {
    case e: DuplicateError => ZIO.succeed(Response(status = Status.Conflict, body = Body.fromString(PublicError.from(e).toJson)))
    ...
  }

so that in my main object, I have:

object Main extends zio.App {
  val app: App[Any] = api.mapErrorZIO(toPublicError)

  override def run = Server.serve(app)
}

When I send a request to this api, I receive a 500 Server Error instead of the 409 Conflict because this piece of code in zio-http fails with a java.util.NoSuchElementException: None.get exception:

package zio.http.internal.middlewares

private[zio] trait HtmlErrorResponses {
  ...
  
  private def formatCause(response: Response): String =
    response.httpError.get.foldCause("") { throwable =>
      s"${scala.Console.BOLD}Cause: ${scala.Console.RESET}\n ${prettify(throwable)}"
    }
    
  ...
}

It doesn't seem that we're able to define an error response with a body in zio-http.
The only function I see to define an error response is Response.fromHttpError(HttpError.Conflict) but it doesn't allow us to pass a body while the ErrorResponse type does take a body:

package zio.http

object Response {
  ...
  
  private[zio] class ErrorResponse(val body: Body, val headers: Headers, val httpError0: HttpError, val status: Status)
      extends Response 
      
  ...
}

Am I missing something?
Shouldn't we be able to define any response type with the Response.apply constructor? 🤔

---

Edit:
After futher investigation, it seems that this issue comes from the beautifyErrors middleware.
When I remove it, my API is correctly answering 409 Conflict

[jdegoes]

/bounty $75

[algora-pbc]

💎 $75 bounty • ZIO

Steps to solve:

1. Start working: Comment /attempt #2295 with your implementation plan
2. Submit work: Create a pull request including /claim #2295 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to zio/zio-http!

Add a bounty • Share on socials

[guersam]

The piece of code calling unsafe Response#httpError.get is gone. Also, there is no Response#httpError anymore.