Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed actions of CassandraAsyncContext propagate error to the caller #993

Closed
mosyp opened this issue Dec 11, 2017 · 1 comment · Fixed by #996
Closed

Failed actions of CassandraAsyncContext propagate error to the caller #993

mosyp opened this issue Dec 11, 2017 · 1 comment · Fixed by #996
Labels

Comments

@mosyp
Copy link
Collaborator

mosyp commented Dec 11, 2017

Version: 2.3.1
Module: quill-cassandra

Expected behavior

Failed actions of CassandraAsyncContext should result in Future.failed

Actual behavior

Failed actions of CassandraAsyncContext is propagated to the caller

Steps to reproduce the behavior

    case class TestEntity(i: Int, s: String)
    val db = new CassandraAsyncContext(Literal, "testAsyncDB")
    import db._

    try {
      val action: Future[List[TestEntity]] = db.run(query[TestEntity].sortBy(_.s))
    } catch {
      case e: Throwable => println(s"error: ${e.getMessage}")
    }
    db.close()

error: ... should not be printed!

@getquill/maintainers

@mosyp mosyp added the bug label Dec 11, 2017
@mosyp
Copy link
Collaborator Author

mosyp commented Dec 11, 2017

it's a regression introduced in #813.
😟
will release a hotfix later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant