Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTelemetry: add ability to set StatusCode in errorMapper based on A #698

Closed
grouzen opened this issue May 25, 2023 · 0 comments · Fixed by #702
Closed

OpenTelemetry: add ability to set StatusCode in errorMapper based on A #698

grouzen opened this issue May 25, 2023 · 0 comments · Fixed by #702
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@grouzen
Copy link
Contributor

grouzen commented May 25, 2023

Taken from #444:

Sometimes, for a ZIO[R, E, A], we also want to set StatusCode based on A. For example, the OpenTelemetry's semantic conventions for HTTP recommends to set StatusCode Error for HTTP status codes in the 4xx and 5xx ranges. So in this case, we need to look into a "successful" response to know which StatusCode to set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OpenTelemetry: add ability to set StatusCode in errorMapper based on A IvanFinochenko/zio-telemetry
1 participant
@grouzen