Fix solidity contract warnings

ziogaschr · Apr 2, 2019 · 12b3660 · 12b3660
1 parent ae4665d
commit 12b3660
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/contracts/CryptoHerosGame.sol b/contracts/CryptoHerosGame.sol
@@ -69,7 +69,7 @@ contract CryptoHerosGame is Ownable {
 
     maxSingleGameId = singleGames.push(_singleGame) - 1;
 
-    uint256[] userSingleGames = usersSingleGames[msg.sender];
+    uint256[] storage userSingleGames = usersSingleGames[msg.sender];
     userSingleGames.push(maxSingleGameId);
 
     return maxSingleGameId;
@@ -85,7 +85,7 @@ contract CryptoHerosGame is Ownable {
 
   function rand(uint min, uint max) private returns (uint){
     nonce++;
-    return uint(sha3(nonce))%(min+max)-min;
+    return uint(keccak256(nonce))%(min+max)-min;
   }
 
   function withdraw(uint amount) public payable onlyOwner returns(bool) {

diff --git a/contracts/CryptoHerosToken.sol b/contracts/CryptoHerosToken.sol
@@ -83,15 +83,15 @@ contract CryptoHerosToken is ERC721Token, Ownable {
 
   function rand(uint min, uint max) private returns (uint){
     nonce++;
-    return uint(sha3(nonce))%(min+max)-min;
+    return uint(keccak256(nonce))%(min+max)-min;
   }
 
   function getHerosLength() external view returns (uint) {
     return heros.length;
   }
 
   function withdraw(uint amount) public payable onlyOwner returns(bool) {
-    require(amount <= this.balance);
+    require(amount <= address(this).balance);
     owner.transfer(amount);
     return true;
   }