Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First heading one the page should be h1 but is h2 #16

Closed
TheDutchCoder opened this issue Aug 25, 2021 · 2 comments
Closed

First heading one the page should be h1 but is h2 #16

TheDutchCoder opened this issue Aug 25, 2021 · 2 comments

Comments

@TheDutchCoder
Copy link

This issue pops up when the first heading in the DOM is not an h1.
This is a false positive, because it's totally fine to have an h2 first depending on where it appears in the markup.

For example, a nav element (that usually precedes the main content) should have a heading and this is often an h2 as there really should only be one h1 (reserved for the main content / page title).

It might be better to check for the amount of h1's and/or check it's within the main of the page.

More info: https://usability.yale.edu/web-accessibility/articles/headings

@ziolko
Copy link
Owner

ziolko commented Aug 28, 2021

Hi @TheDutchCoder, that's exactly the kind of feedback I am looking for. I will release a fix in a few days.

Mateusz

@ziolko
Copy link
Owner

ziolko commented Sep 26, 2021

Hi @TheDutchCoder ,

Seems that the issue detection feature creates more problems than it solves. I am disabling this functionality for now, until I figure out how to do it properly.

A new version of ARIA DevTools with this functionality disabled has been released for Chrome and Firefox and should be available very soon.

Hope this helps,
Mateusz

@ziolko ziolko closed this as completed Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants