This repository has been archived by the owner on Jun 2, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flate2
was pinned to versions <= 1.0.14 in #175, becauseflate2
1.0.15 updated tominiz_oxide
0.4, which accidentally increased its MSRV (#170, Frommi/miniz_oxide#85).This was fixed in
miniz_oxide
0.4.2 (Frommi/miniz_oxide#95), so all published versions offlate2
can once again be built with Rust 1.34.0.Note: Since
flate2
still has a more lax MSRV policy thanzip
, we could make a more conservative change that limits the dependency to versions that are known to work on Rust 1.34:However, I think it would be better, if this breaks again in the future, to fix CI builds by checking in or generating a
Cargo.lock
file for use in MSRV testing.