Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live: Order support for IB Broker #20

Merged
merged 1 commit into from
May 26, 2017
Merged

Live: Order support for IB Broker #20

merged 1 commit into from
May 26, 2017

Conversation

tibkiss
Copy link

@tibkiss tibkiss commented May 26, 2017

The following functions are implemented: order (market, limit, stop & stop limit), cancel_order, get_order, get_open_orders. Testing was done manually since it is pointless to mock out the whole tws & check simple wiring code.

@tibkiss
Copy link
Author

tibkiss commented May 26, 2017

Two errors:

@bartosh
Copy link

bartosh commented May 26, 2017

Interesting. Why tests didn't fail on PR #19 and #12 ?

@pbharrin
Copy link

@bartosh It looks like that treasuries URL stopped working ~13hours ago. So PR #19, and PR #12 probably would have the same error if they were submitted today.

@pbharrin
Copy link

Both the Python 2.7 and 3.4 builds have an error:
No module named ib.ext.EClientSocket
Here is the full stack trace.

PR #12 moving IB to etc/requirements_live_ib.txt caused this. I will add etc/requirements_live_ib.txt to .travis.yml to fix.

@pbharrin pbharrin merged commit 28ee8f0 into zipline-live:live May 26, 2017
@bartosh
Copy link

bartosh commented May 26, 2017

Guys, let's agree not merging PRs until we fix tests. I takes much more time to fix broken target branch than to avoid breaking it.

@bartosh
Copy link

bartosh commented May 26, 2017

PR #12 moving IB to etc/requirements_live_ib.txt caused this. I will add etc/requirements_live_ib.txt to .travis.yml to fix.

PR #12 passed all tests as far as I can see. how come it broke this one?

@tibkiss
Copy link
Author

tibkiss commented May 26, 2017

@pbharrin : May I ask to not to merge PRs which are failing during test?
It is easier to get the broken build fix in the offending PR. Thanks!

@tibkiss
Copy link
Author

tibkiss commented May 26, 2017

@pbharrin : Sorry, I missed that you hotfixed the PR. Please ignore my previous comment. 🤐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants