New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
found some bugs with _fadeoutDuration #15
Comments
@zpz1237 能否发个PR我看下 😁 |
马个鸡... 白扯那么久英文... |
我学一下怎么发PR.. |
Bump! @zipme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have tried to change the
_fadeoutDuration
from 2.5s to another value, but it doesn't workI find that you made mistake in this function,
Maybe you should add
duration
rather thanself.shineDuration
I fixed it but another bug happen, and I fixed it finally with inserting these code below into your
updateAttributedString
You use
self.shineDuration
insetAttributedText
, it will affect the fadeoutAnimation, I add those code to updatecharacterAnimationDurations
to get the right fadeoutAnimation. Need pull request? Hope you can understand my Chiglish :)The text was updated successfully, but these errors were encountered: