Don't Stop 'touchend' Propagation all the time

Details exposed here : #8
zippy1978 · Feb 28, 2013 · 713daa9 · 713daa9
1 parent 7818741
commit 713daa9
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 7 deletions.
diff --git a/dist/jquery.scrollz.css b/dist/jquery.scrollz.css
diff --git a/dist/jquery.scrollz.js b/dist/jquery.scrollz.js
@@ -1,4 +1,4 @@
-/*! jQuery Scrollz - v1.0.3 - 2013-02-24
+/*! jQuery Scrollz - v1.0.3 - 2013-02-28
 * https://github.com/zippy1978/jquery.scrollz
 * Copyright (c) 2013 Gilles Grousset; Licensed MIT, GPL */
 
@@ -135,7 +135,6 @@
             // Add touch end listener
             container.bind(_getTouchEventName($this, 'touchend'), function(event) {
               // Prevent default behaviour
-              event.preventDefault();   
               // Handle
               _handleTouchEndEvent(event, $this);
             });
@@ -593,6 +592,13 @@
       // Nothing to do : touch was already processed
       return;
     }
+
+    // Only prevent the default event from
+    // happening when the user has actually
+    // scrolled
+    if (startTouchY !== lastTouchY) {
+        event.preventDefault();
+    }
 
     var pullHeaderHeight = _getPullHeaderHeight(instance);
 

diff --git a/dist/jquery.scrollz.min.js b/dist/jquery.scrollz.min.js
diff --git a/jquery.scrollz.jquery.json b/jquery.scrollz.jquery.json
@@ -2,7 +2,7 @@
   "name": "jquery.scrollz",
   "title": "jQuery Scrollz",
   "description": "Modern scrolling for jQuery and jQuery Mobile.",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "homepage": "https://github.com/zippy1978/jquery.scrollz",
   "author": {
     "name": "Gilles Grousset",

diff --git a/src/jquery.scrollz.js b/src/jquery.scrollz.js
@@ -131,7 +131,6 @@
             // Add touch end listener
             container.bind(_getTouchEventName($this, 'touchend'), function(event) {
               // Prevent default behaviour
-              event.preventDefault();   
               // Handle
               _handleTouchEndEvent(event, $this);
             });
@@ -589,6 +588,13 @@
       // Nothing to do : touch was already processed
       return;
     }
+
+    // Only prevent the default event from
+    // happening when the user has actually
+    // scrolled
+    if (startTouchY !== lastTouchY) {
+        event.preventDefault();
+    }
 
     var pullHeaderHeight = _getPullHeaderHeight(instance);