Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors with php < 8 #919

Closed
raziel057 opened this issue Mar 24, 2021 · 3 comments
Closed

Errors with php < 8 #919

raziel057 opened this issue Mar 24, 2021 · 3 comments
Labels

Comments

@raziel057
Copy link
Contributor

I just clone the master of the project and when I try to run unit tests using PHP 7.4 I got a lot of errors due to the following commit:
77fee10#diff-c3d05dc2196e7a7fb4469ace41cc580c914ec24d2272eb76920c35f2c0789b74

image

It comes form:

if ($token[0] === T_ATTRIBUTE) {
    // consume
    $this->parseAttribute($tokens, $token, $parseContext);
    continue;
}

Is it expected that the master is not supported by php < 8 ?

@DerManoMann
Copy link
Collaborator

Looks like a bug. Its funny, though, as the build pipeline passes...
However, locally tests break for me the same way...

raziel057 pushed a commit to raziel057/swagger-php that referenced this issue Mar 25, 2021
@michaljusiega
Copy link

See #857

I tried to fix same issue.

DerManoMann pushed a commit that referenced this issue Mar 25, 2021
Related issue #919

Co-authored-by: tlallement <tlallement@incert.lu>
@DerManoMann
Copy link
Collaborator

Fixed via #924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants