Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Response::description optional when $ref is set #1054

Merged
merged 1 commit into from
Jan 9, 2022
Merged

Make Response::description optional when $ref is set #1054

merged 1 commit into from
Jan 9, 2022

Conversation

DerManoMann
Copy link
Collaborator

Fixes #1051

@DerManoMann DerManoMann merged commit c5a5320 into zircote:master Jan 9, 2022
@DerManoMann DerManoMann deleted the response-ref-or-description branch January 9, 2022 20:34
@BusterNeece
Copy link
Contributor

@DerManoMann Looking at this, the PHP 8.1 attribute version of Response now asks for a ref but then does nothing with it. This means that if it's all you have here, it won't ever be set and won't ever validate. Probably a bug that needs fixing (and testing against).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Response shouldn't require description when $ref is provided.
2 participants
@DerManoMann @BusterNeece