Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added resolving references of components (not only schemas) #1544

Merged

Conversation

dkulyk
Copy link
Contributor

@dkulyk dkulyk commented Jan 30, 2024

Includes #1542

Added resolving components like header, requestBody and so.
Berole only schemas can be resolved by AugmentRefs

@dkulyk dkulyk changed the title [feat] Added resolving references of components (not only schemas) feat: Added resolving references of components (not only schemas) Jan 30, 2024
Copy link
Collaborator

@DerManoMann DerManoMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking nice!

A couple nits that would be great to fix.
Sorry for taking so long to review.

src/Processors/AugmentRefs.php Outdated Show resolved Hide resolved
src/Analysis.php Show resolved Hide resolved
src/Processors/AugmentRequestBody.php Outdated Show resolved Hide resolved
tests/Fixtures/Request.php Show resolved Hide resolved
Co-authored-by: Martin Rademacher <mano@radebatz.net>
Copy link
Collaborator

@DerManoMann DerManoMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last bit...

src/Processors/AugmentRefs.php Outdated Show resolved Hide resolved
@DerManoMann DerManoMann merged commit a6d8a93 into zircote:master Feb 18, 2024
21 checks passed
@DerManoMann
Copy link
Collaborator

Thanks @dkulyk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants