Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all annotations added to Analysis have a root context #1586

Merged
merged 1 commit into from
May 2, 2024
Merged

Ensure all annotations added to Analysis have a root context #1586

merged 1 commit into from
May 2, 2024

Conversation

DerManoMann
Copy link
Collaborator

Fixes #1579.

lhausammann
lhausammann approved these changes May 2, 2024
View reviewed changes
Copy link

@lhausammann lhausammann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(i checked the provided examples against that branch and don't see any php-swagger deprecations in phpunit / symfony console anymore. 🎉)

@DerManoMann DerManoMann merged commit 256d42c into zircote:master May 2, 2024
21 checks passed
@DerManoMann DerManoMann deleted the ensure-context-root branch May 2, 2024 21:36
@DerManoMann DerManoMann mentioned this pull request May 2, 2024
Closed
@DjordyKoert DjordyKoert mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhausammann lhausammann lhausammann approved these changes

@deluxetom deluxetom deluxetom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DEPRECATION: Since zircote/swagger-php 4.9: Context detecting is deprecated
3 participants
@DerManoMann @lhausammann @deluxetom