Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement TokenScanner using nikic/php-parser #1597

Merged
merged 6 commits into from
Jun 3, 2024

Conversation

DerManoMann
Copy link
Collaborator

Fixed #1596

@DerManoMann DerManoMann merged commit ddab6a5 into zircote:master Jun 3, 2024
21 checks passed
@DerManoMann DerManoMann deleted the php-parser branch June 3, 2024 08:24
@BusterNeece
Copy link
Contributor

@DerManoMann The latest version of the dev branch is throwing issues on my Composer because several other projects currently depend on version 5.x of php-parser, which is released and stable. If this works with 5.x, you may want to update the composer.json requirements to include 5.x as well.

@DerManoMann
Copy link
Collaborator Author

Hmm, yes, I was wondering. I might roll this back and add it to the V5 branch - php-parser v5 requires >=7.4...

DerManoMann added a commit that referenced this pull request Jun 4, 2024
DerManoMann added a commit that referenced this pull request Jun 4, 2024
DerManoMann added a commit to DerManoMann/swagger-php that referenced this pull request Jun 4, 2024
DerManoMann added a commit to DerManoMann/swagger-php that referenced this pull request Jun 4, 2024
DerManoMann added a commit to DerManoMann/swagger-php that referenced this pull request Jun 6, 2024
DerManoMann added a commit to DerManoMann/swagger-php that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reimplement TokenScanner using nikic/php-parser
2 participants