Fix promoted properties sharing context #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerManoMann
requested changes
Jul 3, 2024
| @@ -80,6 +80,9 @@ public function build(\Reflector $reflector, Context $context): array | |||
| $instance->nullable = $nullable ?: Generator::UNDEFINED; | |||
|
|
|||
| if ($rp->isPromoted()) { | |||
| // ensure each property has its own context | |||
| $instance->_context = clone $instance->_context; | |||
There was a problem hiding this comment.
Not so keen on clone - could we use this instead?
Suggested change
| $instance->_context = clone $instance->_context; | |
| $instance->_context = new Context([], $instance->_context); |
rasmuscnielsen
force-pushed
the
fix/promoted-properties-context
branch
from
7024838
to
1645bd0
Compare
|
Thanks @rasmuscnielsen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reproduction of the bug described in my comment here: #1419 (comment)
Added regression test + fixed it with a clone of context. Tests passing. However - suggestions for alternative fixes are very welcome.