fixed case of UNDEFINED constants namespaces #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! I changed namespace from uppercase to title case, because it causes strange errors like 'Use of undefined constant UNDEFINED - assumed 'UNDEFINED'' in my environment (hhvm 3.13)
|
I also prefer Sadly the PSR-2 style checker disagrees: "Constants must be uppercase" 😞 |
|
@bfanger can you reopen the pull request please? As soon as this pull request is merged squizlabs/PHP_CodeSniffer#1079 it should be possible to merge this request without any errors. |
|
Merged as 202e4c8 |
bfanger
added a commit
that referenced
this pull request
Dec 16, 2016
- Dynamic Definitions / partial support #301 - By default only scan *.php files #350 - Removed silence operator @, improves compatiblity custom errorhandlers #331 - Additional datetime classes & interfaces #338 - Fixed case of UNDEFINED constants namespaces, improves hhvm compatibility #319 - Misc improvements to the docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I changed namespace from uppercase to title case, because it causes strange errors like 'Use of undefined constant UNDEFINED - assumed 'UNDEFINED'' in my environment (hhvm 3.13)