Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

callback always returns state param, even if empty #415

Closed
livio-a opened this issue Jun 27, 2023 · 1 comment · Fixed by #428
Closed

callback always returns state param, even if empty #415

livio-a opened this issue Jun 27, 2023 · 1 comment · Fixed by #428
Assignees
@muhlemmer
Labels
bug Something isn't working released

Comments

@livio-a
Copy link
Member

livio-a commented Jun 27, 2023

As described in the title the state query param is always set in the callback url, e.g. ...&state= which might lead to errors in the client:
https://discord.com/channels/927474939156643850/1121191124493680640
@livio-a livio-a added the bug Something isn't working label Jun 27, 2023
@muhlemmer muhlemmer self-assigned this Aug 18, 2023
muhlemmer added a commit that referenced this issue Aug 18, 2023
@muhlemmer
chore(op): reproduce issue #415
dcbc400
muhlemmer added a commit that referenced this issue Aug 18, 2023
@muhlemmer
fix(op): omit state from code redirect when empty
166fe0f 
Add test cases to reproduce the original bug, and it's resolution.

closes #415
muhlemmer added a commit that referenced this issue Aug 18, 2023
@muhlemmer
fix(op): omit empty state from code flow redirect
11fef51 
Add test cases to reproduce the original bug, and it's resolution.

closes #415
@muhlemmer muhlemmer mentioned this issue Aug 18, 2023
Merged
12 tasks
muhlemmer added a commit that referenced this issue Aug 18, 2023
@muhlemmer
fix(op): omit empty state from code flow redirect (#428)
37b5de0 
* chore(op): reproduce issue #415

* fix(op): omit empty state from code flow redirect

Add test cases to reproduce the original bug, and it's resolution.

closes #415
@github-actions
Copy link

🎉 This issue has been resolved in version 2.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muhlemmer muhlemmer

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(op): omit empty state from code flow redirect zitadel/oidc
2 participants
@muhlemmer @livio-a