Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rp): add a custom claims test for VerifyIDToken #375

Merged
merged 1 commit into from
May 2, 2023

Conversation

muhlemmer
Copy link
Collaborator

Trying to reproduce the issue as reported on discord: https://discord.com/channels/927474939156643850/1096512154515013724

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #375 (147b567) into main (7aa96fe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #375   +/-   ##
=======================================
  Coverage   51.39%   51.39%           
=======================================
  Files          74       74           
  Lines        5676     5676           
=======================================
  Hits         2917     2917           
  Misses       2495     2495           
  Partials      264      264           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@muhlemmer
Copy link
Collaborator Author

It didn't reproduce any bug, but it doesn't harm to have an extra test case.

@muhlemmer muhlemmer marked this pull request as ready for review April 24, 2023 09:07
@muhlemmer muhlemmer enabled auto-merge (squash) April 24, 2023 09:07
@muhlemmer muhlemmer disabled auto-merge April 24, 2023 09:08
@muhlemmer muhlemmer enabled auto-merge (squash) April 24, 2023 09:08
@muhlemmer muhlemmer changed the title rp: add a custom claims test for VerifyIDToken chore(rp): add a custom claims test for VerifyIDToken Apr 26, 2023
@muhlemmer muhlemmer disabled auto-merge April 26, 2023 09:29
@muhlemmer muhlemmer enabled auto-merge (squash) April 26, 2023 09:30
@muhlemmer muhlemmer merged commit edf3062 into main May 2, 2023
@muhlemmer muhlemmer deleted the rp-verifyidtoken-test branch May 2, 2023 09:31
@github-actions
Copy link

github-actions bot commented May 3, 2023

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants