fix: don't error on invalid i18n tags in discovery #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the use of `[]language.Tag` to `oidc.Locales` in `DiscoveryConfig`. This should be compatible with callers that use the `[]language.Tag` . Locales now implements the `json.Unmarshaler` interface. With support for json arrays or space seperated strings. The latter because `UnmarshalText` might have been implicetely called by the json library before we added UnmarshalJSON. Fixes: #406
Codecov Report
@@ Coverage Diff @@
## main #407 +/- ##
==========================================
+ Coverage 52.08% 52.28% +0.20%
==========================================
Files 74 74
Lines 5687 5711 +24
==========================================
+ Hits 2962 2986 +24
Misses 2461 2461
Partials 264 264
|
stebenz
approved these changes
Jun 9, 2023
|
🎉 This PR is included in version 2.6.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the use of
[]language.Tagtooidc.LocalesinDiscoveryConfig. This should be compatible with callers that use the[]language.Tag.Locales now implements the
json.Unmarshalerinterface. With support for json arrays or space seperated strings. The latter becauseUnmarshalTextmight have been implicitly called by the json library before we addedUnmarshalJSON.Fixes: #406
Definition of Ready
Where possible E2E tests are implementedFunctionality of the acceptance criteria is checked manually on the dev system.