fix(client/rs): do not error when issuer discovery has no introspection endpoint #414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
client/rs
to not error when an issuer discovery returns no introspection endpoint.Summary of changes:
newResourceServer()
will only fillrs.tokenURL
andrs.introspectURL
if they were not given as static endpoints usingWithStaticEndpoints()
. This allows the discovery mechanism to always respect the user-provided static endpoints and only fill them when one or the other was not statically provided. Also, given thatconfig.introspectURL
is optional in the OIDC Discovery spec, it is no longer enforced to be present after discovery.Introspect()
will now fail if the passedResourceServer
does not have anIntrospectionURL()
set. This allows for graceful errors in case issuers do not provide an introspection endpoint.Fixes #413
Definition of Ready