Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete PKCE cookie after code exchange #419

Merged
merged 1 commit into from
Aug 14, 2023
Merged

feat: delete PKCE cookie after code exchange #419

merged 1 commit into from
Aug 14, 2023

Conversation

gandaldf
Copy link
Contributor

@gandaldf gandaldf commented Aug 2, 2023

Perhaps it would be better to delete the PKCE cookie once the code exchange has been successfully completed?
It's just a line of code but if I missed something of the big picture, feel free to close this PR.

@hifabienne
Copy link
Member

hei @muhlemmer can you have a look at this?

Copy link
Collaborator

@muhlemmer muhlemmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@muhlemmer muhlemmer enabled auto-merge (squash) August 14, 2023 15:13
@muhlemmer muhlemmer changed the title Delete PKCE cookie after code exchange feat: delete PKCE cookie after code exchange Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #419 (d180978) into main (be89c3b) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #419   +/-   ##
=======================================
  Coverage   52.69%   52.69%           
=======================================
  Files          74       74           
  Lines        5724     5725    +1     
=======================================
+ Hits         3016     3017    +1     
  Misses       2446     2446           
  Partials      262      262           
Files Changed Coverage Δ
pkg/client/rp/relying_party.go 50.55% <100.00%> (+0.13%) ⬆️

@muhlemmer muhlemmer merged commit 45582b6 into zitadel:main Aug 14, 2023
8 checks passed
@github-actions
Copy link

🎉 This PR is included in version 2.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants