feat: delete PKCE cookie after code exchange #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hei @muhlemmer can you have a look at this? |
muhlemmer
changed the title
Codecov Report
@@ Coverage Diff @@
## main #419 +/- ##
=======================================
Coverage 52.69% 52.69%
=======================================
Files 74 74
Lines 5724 5725 +1
=======================================
+ Hits 3016 3017 +1
Misses 2446 2446
Partials 262 262
|
|
🎉 This PR is included in version 2.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps it would be better to delete the PKCE cookie once the code exchange has been successfully completed?
It's just a line of code but if I missed something of the big picture, feel free to close this PR.