Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exampleop): pass the issuer interceptor to login #430

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

muhlemmer
Copy link
Collaborator

Use the IssuerInterceptor in the exampleop package, so that the issuer is correctly set to the context. Withouth the interceptor, AuthCallbackURL would return only relative paths. This breaks users addapting the example with a custom issuer prefix.

Notes:

  1. Prefix handling worked find for all the op handlers. It was just the login in exampleop that failed to set the issuer to the context correctly.
  2. The dynamic example was also correct with the IssuerInterceptor.

Testing was done manually and then rolled back. See commit ee72eb0.

Closes #408

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria aret met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #430 (ee72eb0) into main (37b5de0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #430   +/-   ##
=======================================
  Coverage   53.31%   53.31%           
=======================================
  Files          74       74           
  Lines        5725     5725           
=======================================
  Hits         3052     3052           
  Misses       2414     2414           
  Partials      259      259           

@muhlemmer muhlemmer requested a review from livio-a August 18, 2023 15:52
@muhlemmer muhlemmer enabled auto-merge (squash) August 18, 2023 15:53
@muhlemmer muhlemmer merged commit ce85a8b into main Aug 21, 2023
8 checks passed
@muhlemmer muhlemmer deleted the fix-authURL-prefix branch August 21, 2023 05:44
@github-actions
Copy link

🎉 This PR is included in version 2.8.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AuthCallbackURL removes issuer path prefix
2 participants