-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added the ability to verify ID tokens using the value of id_token_signing_alg_values_supported retrieved from DiscoveryEndpoint #579
Conversation
I would like to add a test to check the behavior of the function I am adding, which is the best way to implement it? |
You could add an integration test that starts the example OP and then initialize the RP with your the new option. oidc/pkg/client/integration_test.go Lines 63 to 71 in 8a21d38
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
+ Coverage 60.06% 62.17% +2.11%
==========================================
Files 80 81 +1
Lines 6998 6192 -806
==========================================
- Hits 4203 3850 -353
+ Misses 2498 2037 -461
- Partials 297 305 +8 ☔ View full report in Codecov by Sentry. |
@otakakot I understood you still want to add tests, is that correct? I am waiting with the review until that's done. |
@muhlemmer Excuse me, may I have a review at this stage? |
The implementation looks good to me 👍 |
7572353 Tests have been added. |
🎉 This PR is included in version 3.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Definition of Ready
fixes #574
Fixed
discoveryConfiguration.IDTokenSigningAlgValuesSupported
to be set toWithSupportedSigningAlgorithms()
.I thought about adding and setting
discoveryConfiguration
to therelyingParty
struct field and doingfor _, optFunc := range options{}
after gettingdiscoveryConfiguration
,WithCustomDiscoveryUrl()
had to be processed beforeclient.Discover()
.