fix: remove NotBefore attribute from SubjectConfirmationData (#57) (#58)

zitadel · Sep 15, 2023 · dd53243 · dd53243
1 parent afbec8e
commit dd53243
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/pkg/provider/response.go b/pkg/provider/response.go
@@ -261,7 +261,6 @@ func makeAssertion(
 					Method: "urn:oasis:names:tc:SAML:2.0:cm:bearer",
 					SubjectConfirmationData: &saml.SubjectConfirmationDataType{
 						InResponseTo: requestID,
-						NotBefore:    issueInstant,
 						NotOnOrAfter: untilInstant,
 					},
 				},

diff --git a/pkg/provider/xml/saml/models.go b/pkg/provider/xml/saml/models.go
@@ -67,7 +67,6 @@ type SubjectConfirmationType struct {
 
 type SubjectConfirmationDataType struct {
 	XMLName      xml.Name `xml:"urn:oasis:names:tc:SAML:2.0:assertion SubjectConfirmationData"`
-	NotBefore    string   `xml:"NotBefore,attr,omitempty"`
 	NotOnOrAfter string   `xml:"NotOnOrAfter,attr,omitempty"`
 	Recipient    string   `xml:"Recipient,attr,omitempty"`
 	InResponseTo string   `xml:"InResponseTo,attr,omitempty"`