Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use html/template for SAML POST/Logout templates #32

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

coelho
Copy link
Contributor

@coelho coelho commented Oct 28, 2022

Follow up to #29 - Looks like the previous patch was incomplete.

Currently text/template is used, which does not properly HTML Encode the HTML Form values used in SAML POST/Logout flows.
Switching to html/template resolves this issue.

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #32 (0c5648c) into main (80e4820) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   47.38%   47.38%           
=======================================
  Files          21       21           
  Lines        1967     1967           
=======================================
  Hits          932      932           
  Misses        977      977           
  Partials       58       58           
Impacted Files Coverage Δ
pkg/provider/identityprovider.go 56.06% <ø> (ø)
pkg/provider/logout_response.go 0.00% <ø> (ø)
pkg/provider/response.go 61.34% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coelho
Copy link
Contributor Author

coelho commented Oct 30, 2022

Added 0c5648c

Confirmed with these patches:

  • Login is working perfect with Google third-party SAML login.
  • Logout still seems buggy (infinite redirect loop), but this is not a regression. It does not work in prior versions either.

Let me know if you have any questions.

@mffap
Copy link
Member

mffap commented Oct 30, 2022

@stebenz could you take this over?
@hifabienne would it make sense to extend the action and also assign PRs to the kanban board?

@hifabienne
Copy link
Member

@stebenz could you take this over? @hifabienne would it make sense to extend the action and also assign PRs to the kanban board?

Not sure, because most of the time a pr is linked to an issue, if we have both on the board it is kind of duplicate

@stebenz stebenz merged commit e9cc5c7 into zitadel:main Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

🎉 This PR is included in version 0.0.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants