fix: handle redirect loop

[stebenz]

Definition of Ready

• I am happy with the code
• Short description of the feature/issue is added in the pr description
• PR is linked to the corresponding user story
• Acceptance criteria are met
• All open todos and follow ups are defined in a new ticket and justified
• Deviations from the acceptance criteria and design are agreed with the PO and documented.
• No debug or dead code
• My code has no repetitions
• Critical parts are tested automatically
• Where possible E2E tests are implemented
• Documentation/examples are up-to-date
• All non-functional requirements are met
• Functionality of the acceptance criteria is checked manually on the dev system.

[codecov]

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (45a75c4) 47.25% compared to head (0afe35b) 47.36%.

Files	Patch %	Lines
pkg/provider/logout_response.go	0.00%	7 Missing ⚠️
pkg/provider/response.go	50.00%	4 Missing and 2 partials ⚠️
pkg/provider/xml/xml.go	40.00%	3 Missing ⚠️
pkg/provider/logout.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   47.25%   47.36%   +0.11%     
==========================================
  Files          21       21              
  Lines        1983     1974       -9     
==========================================
- Hits          937      935       -2     
+ Misses        988      981       -7     
  Partials       58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[livio-a]

can you please give me some context about this PR

[stebenz]

@livio-a Sure, if you fail to login or logout in SAMl you're supposed to get a code 200 and a response with what went wrong.
The problem here is that the response should be delivered to the serviceprovider, but if no serviceprovider matches with the request or the request can't be read correctly(empty, decoding error, unmarshalling error) the URL where the response should be send to is empty. An empty response URL with post-binding results in a from post with empty URL, which ends in a redirect loop.

Was mentioned in a discord discussion I think, and as I had a look at it I could also just fix it.

[github-actions]

🎉 This PR is included in version 0.1.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀