Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

login prompt, callback handler #58

Merged
merged 29 commits into from
Mar 15, 2024
Merged

login prompt, callback handler #58

merged 29 commits into from
Mar 15, 2024

Conversation

peintnermax
Copy link
Member

@peintnermax peintnermax commented Mar 6, 2024 •
edited
Loading

Implement login and select_account prompt, debug mode to show navigation

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Jest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

@vercel Vercel
Copy link

vercel bot commented Mar 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 3:37pm

@peintnermax peintnermax marked this pull request as ready for review March 13, 2024 08:22
eliobischof
eliobischof requested changes Mar 14, 2024
View reviewed changes
apps/login/app/(login)/layout.tsx Outdated Show resolved Hide resolved
apps/login/app/(login)/login/route.ts Outdated Show resolved Hide resolved
apps/login/app/(login)/login/route.ts Show resolved Hide resolved
apps/login/app/(login)/login/route.ts Outdated Show resolved Hide resolved
apps/login/app/(login)/login/route.ts Outdated Show resolved Hide resolved
apps/login/app/layout.tsx Outdated Show resolved Hide resolved
apps/login/middleware.ts Show resolved Hide resolved
peintnermax and others added 3 commits March 14, 2024 14:42
@peintnermax @eliobischof
Update apps/login/app/(login)/layout.tsx
aa7a404 
Co-authored-by: Elio Bischof <elio@zitadel.com>
@peintnermax @eliobischof
Update apps/login/app/(login)/login/route.ts
5f5f6f3 
Co-authored-by: Elio Bischof <elio@zitadel.com>
@peintnermax @eliobischof
Update apps/login/app/layout.tsx
0e9928d 
Co-authored-by: Elio Bischof <elio@zitadel.com>
@peintnermax peintnermax merged commit 952a1c8 into main Mar 15, 2024
5 checks passed
@peintnermax peintnermax deleted the qa branch March 15, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliobischof eliobischof eliobischof requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peintnermax @eliobischof