Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add client2 tmp pkg #73

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

yordis
Copy link
Contributor

@yordis yordis commented May 28, 2024

Related to #63 Instead of breaking changes, we can merge a "new package" called client2 and once the migration is done rename it to be just client and remove the old one.

Copy link

vercel bot commented May 28, 2024

@yordis is attempting to deploy a commit to the zitadel Team on Vercel.

A member of the Team first needs to authorize it.

@yordis yordis force-pushed the add-clientv2 branch 3 times, most recently from 5d8fdcd to 8c25362 Compare May 28, 2024 05:10
@yordis yordis marked this pull request as ready for review May 28, 2024 05:19
@peintnermax
Copy link
Member

Nice work. Yeah renaming makes sense to me 👍
Can you add a fresh pnpm-lock.yaml as it is updated on my machine after I run the install command..
Also can't figure out why pnpm generate outputs into packages/zitadel-proto/zitadel and not into packages/zitadel-proto/proto/zitadel like it is stated in the package script 🤔

@yordis
Copy link
Contributor Author

yordis commented May 28, 2024

packages/zitadel-proto/zitadel

That is the correct path!

"outputs": ["zitadel/**"],

it is stated in the package script 🤔

Which package script?

That ./proto/zitadel from

"generate": "buf generate https://github.com/zitadel/zitadel.git --path ./proto/zitadel",
is the path inside the repository that has the proto files, that is not the output path.

This is the output path:

That output path is configured following as close as possible buf.build (eg: https://buf.build/googleapis/googleapis/sdks)

@peintnermax
Copy link
Member

packages/zitadel-proto/zitadel

That is the correct path!

"outputs": ["zitadel/**"],

it is stated in the package script 🤔

Which package script?

That ./proto/zitadel from

"generate": "buf generate https://github.com/zitadel/zitadel.git --path ./proto/zitadel",

is the path inside the repository that has the proto files, that is not the output path.
This is the output path:

That output path is configured following as close as possible buf.build (eg: https://buf.build/googleapis/googleapis/sdks)

got confused by the same commands but different outputs 👍

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 2:48pm

@peintnermax peintnermax merged commit df73742 into zitadel:main May 28, 2024
6 checks passed
@yordis yordis deleted the add-clientv2 branch May 28, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants