Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: setup with secret config #181

Merged
merged 3 commits into from
Mar 11, 2024
Merged

fix: setup with secret config #181

merged 3 commits into from
Mar 11, 2024

Conversation

eliobischof
Copy link
Member

Config provided using a referenced secret has no effect for the setup job. This PR fixes this.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@eliobischof eliobischof self-assigned this Mar 1, 2024
@eliobischof eliobischof linked an issue Mar 1, 2024 that may be closed by this pull request
[Bug]: when config.yaml is stored in a kubernetes secret certain values are ignored #171
Closed
2 tasks
@eliobischof eliobischof requested a review from stebenz March 1, 2024 08:37
@eliobischof eliobischof mentioned this pull request Mar 1, 2024
Closed
2 tasks
stebenz
stebenz previously approved these changes Mar 4, 2024
View reviewed changes
@eliobischof
Copy link
Member Author

eliobischof commented Mar 4, 2024 •
edited

@stebenz I updated the conflicting version and disabled auto dismissing stale PR reviews in the branch protections.

@eliobischof eliobischof requested a review from stebenz March 4, 2024 11:04
@eliobischof eliobischof enabled auto-merge (squash) March 4, 2024 11:05
@eliobischof eliobischof merged commit 2b72260 into main Mar 11, 2024
9 checks passed
@eliobischof eliobischof deleted the fix-setup-from-secret branch March 11, 2024 14:46
kleberbaum pushed a commit to fhkit/zitadel-charts that referenced this pull request May 24, 2024
@eliobischof
fix: setup with secret config (zitadel#181)
58fbd96 
* fix: setup with secret config

* patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stebenz stebenz stebenz approved these changes

Assignees

@eliobischof eliobischof

Labels
None yet
Projects
Product Management
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: when config.yaml is stored in a kubernetes secret certain values are ignored
2 participants
@eliobischof @stebenz