Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add additionalLabels to Jobs #190

Merged
merged 2 commits into from
Mar 27, 2024
Merged

feat: Add additionalLabels to Jobs #190

merged 2 commits into from
Mar 27, 2024

Conversation

bjw-s
Copy link
Contributor

@bjw-s bjw-s commented Mar 21, 2024

Description

This PR is an extension of #172, and allows additional Pod labels to be set on the init and setup Jobs. This (for example) allows NetworkPolicies to target them as well as the main Pod.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@hifabienne hifabienne added os-contribution This is a contribution from our open-source community devops labels Mar 21, 2024
@hifabienne hifabienne requested a review from stebenz March 21, 2024 10:31
@stebenz stebenz merged commit 9050cac into zitadel:main Mar 27, 2024
9 checks passed
@bjw-s bjw-s deleted the job-labels branch March 27, 2024 13:38
kleberbaum pushed a commit to fhkit/zitadel-charts that referenced this pull request May 24, 2024
@bjw-s @stebenz
feat: Add additionalLabels to Jobs (zitadel#190)
2a935b6 
Co-authored-by: Stefan Benz <46600784+stebenz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stebenz stebenz stebenz approved these changes

Assignees
No one assigned
Labels
devops os-contribution This is a contribution from our open-source community
Projects
Product Management
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bjw-s @stebenz @hifabienne