fix: remove illegal characters from port name

[ameijboom]

While deploying Zitadel on our test cluster, we encountered an issue with the port name that was caused by the appProtocol we're using.

Invalid value: "kubernetes.io/h2c-server": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric charact
er (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')

In this PR, we strip invalid characters from the protocol in the port name of the service.

Definition of Ready

• I am happy with the code
• Short description of the feature/issue is added in the pr description
• PR is linked to the corresponding user story
• Acceptance criteria are met
• All open todos and follow ups are defined in a new ticket and justified
• Deviations from the acceptance criteria and design are agreed with the PO and documented.
• No debug or dead code
• My code has no repetitions
• Documentation/examples are up-to-date
• All non-functional requirements are met
• If possible, the test configuration is adjusted so acceptance tests cover my changes

[eliobischof]

Thanks for the PR.

At least the port reference in the service monitor needs to be updated too, right?

[ameijboom]

You're correct. I've updated my PR accordingly.

[eliobischof]

You're correct. I've updated my PR accordingly.

I don't see the change 😄

[ameijboom]

Blunder on my part, should be all good now.

[eliobischof]

Hey @ameijboom, thanks for the fix.

If you'd like us to send you a small gift, please send us a mail to hi@zitadel.com. You will receive a form with questions like your shirt size and address.