Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support extraVolumes and extraVolumeMounts #205

Merged
merged 1 commit into from
May 24, 2024

Conversation

cr1cr1
Copy link
Contributor

@cr1cr1 cr1cr1 commented May 23, 2024

closes #127

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label May 23, 2024
@eliobischof eliobischof self-assigned this May 24, 2024
@eliobischof eliobischof self-requested a review May 24, 2024 21:27
@eliobischof eliobischof changed the title Add extraVolumes and extraVolumeMounts; closes #127 feat: support extraVolumes and extraVolumeMounts May 24, 2024
Copy link
Member

@eliobischof eliobischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great feature @cr1cr1 🥳

If you'd like us to send you a small gift in return, please send us a mail to hi@zitadel.com. We will send you a form with questions about your shirt size and address.

@eliobischof eliobischof merged commit 68cc3e3 into zitadel:main May 24, 2024
11 checks passed
@cr1cr1
Copy link
Contributor Author

cr1cr1 commented May 27, 2024

@eliobischof thank you very much for the offer, it is unexpected and very appreciated.
I do not need a t-shirt, I just hope you keep building this great tool.

@aminebt
Copy link

aminebt commented Jun 28, 2024

Thanks for this very useful feature. We're actually using it to answer two use-cases to fetch desired info from secrets :
1/ providing SystemAPI public key (configured through a "Path" instead of the explicit public key)
2/ providing CA certificate to enable LDAPS

In our use-cases, (2) is optional whereas (1) should always be there. So a very handy addition could be adding the tpl function in the template for both extraVolumes and extraVolumesMounts :
{{- tpl (toYaml .) $ | nindent 10 }}
instead of
{{- toYaml . | nindent 10 }}

I think this would empower us to add arbitrary templating logic to the values themselves, and is compatible with the current usage of extraVolumes and extraVolumesMounts. For example, in our use-cases above, we could customize templating such that (1) is always there whereas (2) depends on another value.

Happy to get other suggestions/alternatives to customize further the chart deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os-contribution This is a contribution from our open-source community
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature] Add the possibility to add CA certificates as volumes/config
4 participants