fix: remove app name check on ChangeAPIApplication (#1561)

* fix: remove app name check on ChangeAPIApplication * fix APIConfigInvalid message
zitadel · Apr 9, 2021 · 188938e · 188938e
1 parent e7913bd
commit 188938e
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 23 deletions.
diff --git a/internal/command/project_application_api.go b/internal/command/project_application_api.go
@@ -69,7 +69,7 @@ func (c *Commands) addAPIApplication(ctx context.Context, projectAgg *eventstore
 }
 
 func (c *Commands) ChangeAPIApplication(ctx context.Context, apiApp *domain.APIApp, resourceOwner string) (*domain.APIApp, error) {
-	if !apiApp.IsValid() || apiApp.AppID == "" || apiApp.AggregateID == "" {
+	if apiApp.AppID == "" || apiApp.AggregateID == "" {
 		return nil, caos_errs.ThrowInvalidArgument(nil, "COMMAND-1m900", "Errors.Project.App.APIConfigInvalid")
 	}
 

diff --git a/internal/command/project_application_api_test.go b/internal/command/project_application_api_test.go
@@ -272,27 +272,6 @@ func TestCommandSide_ChangeAPIApplication(t *testing.T) {
 		args   args
 		res    res
 	}{
-		{
-			name: "invalid app, invalid argument error",
-			fields: fields{
-				eventstore: eventstoreExpect(
-					t,
-				),
-			},
-			args: args{
-				ctx: context.Background(),
-				apiApp: &domain.APIApp{
-					ObjectRoot: models.ObjectRoot{
-						AggregateID: "project1",
-					},
-					AppID: "app1",
-				},
-				resourceOwner: "org1",
-			},
-			res: res{
-				err: caos_errs.IsErrorInvalidArgument,
-			},
-		},
 		{
 			name: "missing appid, invalid argument error",
 			fields: fields{

diff --git a/internal/static/i18n/en.yaml b/internal/static/i18n/en.yaml
@@ -194,7 +194,7 @@ Errors:
       NotActive:: Application is not active
       NotInactive: Application is not inactive
       OIDCConfigInvalid: OIDC configuration is invalid
-      APIConfigInvalid: OIDC configuration is invalid
+      APIConfigInvalid: API configuration is invalid
       IsNotOIDC: Application is not type oidc
       IsNotAPI: Application is not type API
       OIDCAuthMethodNoSecret: Chosen OIDC Auth Method does not require a secret