Skip to content

Commit

Permalink
fix: use singleton meter provider (#5725)
Browse files Browse the repository at this point in the history
  • Loading branch information
eliobischof committed Apr 25, 2023
1 parent c12c2f0 commit 923f691
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions internal/telemetry/metrics/otel/open_telemetry.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (
)

type Metrics struct {
Exporter *prometheus.Exporter
Provider metric.MeterProvider
Meter metric.Meter
Counters sync.Map
UpDownSumObserver sync.Map
Expand All @@ -34,12 +34,13 @@ func NewMetrics(meterName string) (metrics.Metrics, error) {
if err != nil {
return &Metrics{}, err
}
meterProvider := sdk_metric.NewMeterProvider(
sdk_metric.WithReader(exporter),
sdk_metric.WithResource(resource),
)
return &Metrics{
Exporter: exporter,
Meter: sdk_metric.NewMeterProvider(
sdk_metric.WithReader(exporter),
sdk_metric.WithResource(resource),
).Meter(meterName),
Provider: meterProvider,
Meter: meterProvider.Meter(meterName),
}, nil
}

Expand All @@ -48,7 +49,7 @@ func (m *Metrics) GetExporter() http.Handler {
}

func (m *Metrics) GetMetricsProvider() metric.MeterProvider {
return sdk_metric.NewMeterProvider(sdk_metric.WithReader(m.Exporter))
return m.Provider
}

func (m *Metrics) RegisterCounter(name, description string) error {
Expand Down

1 comment on commit 923f691

@vercel
Copy link

@vercel vercel bot commented on 923f691 Apr 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

docs – ./

docs-git-main-zitadel.vercel.app
zitadel-docs.vercel.app
docs-zitadel.vercel.app

Please sign in to comment.