fix(queries): login policy projection #2401
Conversation
bulk iterates as long as new events
…st statement if it has previous sequence 0
no savepoint if noop stmt, tests for stmt handler
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return &mgmt_pb.GetLoginPolicyResponse{Policy: policy_grpc.ModelLoginPolicyToPb(policy), IsDefault: policy.Default}, nil | ||
| //TODO: why do we provice IsDefault twice? |
There was a problem hiding this comment.
Is default should only be shown once. I think this happend on last api refactoring, because of the sub protos.
I think we should deprecate it in the api. So we can remove it in the future
| Sequence: policy.Sequence, | ||
| CreationDate: timestamp_pb.New(policy.CreationDate), | ||
| ChangeDate: timestamp_pb.New(policy.ChangeDate), | ||
| ResourceOwner: policy.OrgID, //TODO: should resource owner always be the org from ctx? |
There was a problem hiding this comment.
What do you mean with this comment?
There was a problem hiding this comment.
i have no idea. deleted the comment
| ForceMFA bool | ||
| HidePasswordReset bool | ||
| PasswordlessType PasswordlessType | ||
| SecondFactors []SecondFactorType | ||
| MultiFactors []MultiFactorType | ||
| SecondFactors []domain.SecondFactorType | ||
| MultiFactors []domain.MultiFactorType | ||
| Default bool | ||
|
|
||
| CreationDate time.Time |
There was a problem hiding this comment.
where do we need this view model? wouldn't it make sense to use the domain model?
There was a problem hiding this comment.
it's needed in the AuthRequest-struct. I would not remove it now as not all objects in AuthRequest are changed
internal/query/policy_login.go
Outdated
| ) | ||
| if err != nil { | ||
| if errs.Is(err, sql.ErrNoRows) { | ||
| return nil, errors.ThrowNotFound(err, "QUERY-yPqIZ", "errors.login_policy.not_found") |
There was a problem hiding this comment.
This error message is wrong. should start with upper case
internal/query/policy_login.go
Outdated
| ) | ||
| if err != nil { | ||
| if errs.Is(err, sql.ErrNoRows) { | ||
| return nil, errors.ThrowNotFound(err, "QUERY-yPqIZ", "errors.login_policy.not_found") |
| @@ -0,0 +1 @@ | |||
| ALTER TABLE zitadel.projections.orgs RENAME COLUMN domain TO primary_domain; | |||
| @@ -0,0 +1,13 @@ | |||
| CREATE TABLE zitadel.projections.org_domains ( | |||
| @@ -0,0 +1,20 @@ | |||
| CREATE TABLE zitadel.projections.login_policies ( | |||
error messages, migrations
Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
…adel into login-policy-projection
|
🎉 This PR is included in version 1.47.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
merge after #2383