Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metadata): corrected handling of remove metadata events #4505

Merged
merged 3 commits into from
Oct 7, 2022

Conversation

stebenz
Copy link
Collaborator

@stebenz stebenz commented Oct 6, 2022

No description provided.

@stebenz stebenz added bug Something isn't working lang: go Pull requests that update Go code backend labels Oct 6, 2022
@stebenz stebenz self-assigned this Oct 6, 2022
@netlify
Copy link

netlify bot commented Oct 6, 2022

Deploy Preview for docs-zitadel-com canceled.

Name Link
🔨 Latest commit c328cad
🔍 Latest deploy log https://app.netlify.com/sites/docs-zitadel-com/deploys/633ff01ad14ecf0009d0902e

Copy link
Member

@hifabienne hifabienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it work for users and orgs now? i think the error also occured on the users.

@livio-a livio-a enabled auto-merge (squash) October 7, 2022 09:23
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #4505 (c328cad) into main (c6bb797) will decrease coverage by 0.11%.
The diff coverage is 39.36%.

@@            Coverage Diff             @@
##             main    #4505      +/-   ##
==========================================
- Coverage   46.99%   46.87%   -0.12%     
==========================================
  Files         632      640       +8     
  Lines       56802    57308     +506     
==========================================
+ Hits        26694    26865     +171     
- Misses      28766    29087     +321     
- Partials     1342     1356      +14     
Impacted Files Coverage Δ
internal/actions/api.go 0.00% <0.00%> (ø)
internal/actions/context.go 0.00% <0.00%> (ø)
internal/actions/log_module.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/export.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/import.go 0.00% <0.00%> (ø)
internal/api/grpc/admin/login_policy_converter.go 0.00% <0.00%> (ø)
internal/api/grpc/management/flow.go 0.00% <0.00%> (ø)
internal/api/grpc/management/org.go 0.00% <0.00%> (ø)
...rnal/api/grpc/management/policy_login_converter.go 0.00% <0.00%> (ø)
...epository/eventsourcing/eventstore/auth_request.go 26.01% <0.00%> (-0.44%) ⬇️
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@livio-a livio-a merged commit c9e2e6b into main Oct 7, 2022
@livio-a livio-a deleted the metadata-remove-fix branch October 7, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working lang: go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants