-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle UserLoginMustBeDomain changes correctly #4765
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-zitadel-com canceled.
|
Codecov Report
@@ Coverage Diff @@
## main #4765 +/- ##
==========================================
+ Coverage 46.64% 46.79% +0.14%
==========================================
Files 641 641
Lines 60280 60442 +162
==========================================
+ Hits 28120 28286 +166
+ Misses 30766 30757 -9
- Partials 1394 1399 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hifabienne
reviewed
Nov 28, 2022
1 task
hifabienne
approved these changes
Dec 6, 2022
peintnermax
added a commit
that referenced
this pull request
Dec 19, 2022
* docs: add tailwindcss for styles, oidc authorize endpoint playground (#4707) * variable parser * rm plugin * set fcn * env * EnvCode component * cleanup env demo * env * rm remark plugin * auth request context * auth req component * authorize endpoint construction * rev react page * fix endpoint * styling * query params with anchor * desc * tailwind coexistence * fix styles * add login_hint, organizationId scope * auth request without prompt * show login_hint * sync displayed url with actual href * fix fcn * coloring * Update docs/src/components/authrequest.jsx Co-authored-by: mffap <mpa@zitadel.com> * Update docs/src/components/authrequest.jsx Co-authored-by: mffap <mpa@zitadel.com> * Update docs/src/components/authrequest.jsx Co-authored-by: mffap <mpa@zitadel.com> * Update docs/src/components/authrequest.jsx Co-authored-by: mffap <mpa@zitadel.com> * Update docs/src/components/authrequest.jsx Co-authored-by: mffap <mpa@zitadel.com> * Update docs/src/components/authrequest.jsx Co-authored-by: mffap <mpa@zitadel.com> * add plausible, header * add pkce * move * adds pkce code challenge * replace cboa * reaname and move to required * fall back to cboa due to webpack error * trailing slash * reorder org_id * remove resourceowner * texts * update references * buffer, fix some react dom components * Apply suggestions from code review Co-authored-by: Florian Forster <florian@zitadel.com> * standard scopes Co-authored-by: mffap <mpa@zitadel.com> Co-authored-by: Florian Forster <florian@zitadel.com> * fix: handle UserLoginMustBeDomain changes correctly (#4765) * fix: handle UserLoginMustBeDomain changes correctly * fix: remove verified domains (and not only primary) as suffix * fix: ensure testability by changing map to slice * cleanup * reduce complexity of DomainPolicyUsernamesWriteModel.Reduce() * add test for removed org policy * chore(docs): fix links for domain migration (#4831) * chore(docs): fix links for domain migration * try trailing slash for netlify * trial * fix typo * test path * try preview proxied * test local proxy * try to define the domain with redirect to /docs * remove build commands * debug netlify router and fix image link * working config * fix analytics * chore(docs): remove analytics proxy from preview (#4842) * chore(docs): analytics proxy fix * Update netlify.toml * chore: replace docs links (#4843) * chore: replace docs links * Update index.js * prettier * docs(import): correct import example from v1 with timeout (#4731) Co-authored-by: Livio Spring <livio.a@gmail.com> * fix: corrected statement to when an init code has to be sent (#4817) * fix: corrected statement to when an init code has to be sent * fix: corrected statement to when an init code has to be sent * fix: corrected statement to when an init code has to be sent * fix: add init code to user handle for auth.users2 Co-authored-by: Livio Spring <livio.a@gmail.com> * fix: remove domain and user correctly in DomainPolicyUsernamesWriteModel (#4850) fix: remove Domain and User correctly in DomainPolicyUsernamesWriteModel * fix(database): add `MaxIdleConns` configuration (#4856) * docs: fix h2c link (#4846) * docs: fix h2c link * Update http2.mdx Co-authored-by: Elio Bischof <eliobischof@gmail.com> * fix: compute usernames in auth views correctly after domain policy change (#4860) * fix: compute usernames in auth views correctly after domain policy change * userloginmustbedomain hint Co-authored-by: Max Peintner <max@caos.ch> * feat: Instance create (#4502) * feat(instance): implement create instance with direct machine user and credentials * fix: deprecated add endpoint and variable declaration * fix(instance): update logic for pats and machinekeys * fix(instance): unit test corrections and additional unit test for pats and machinekeys * fix(instance-create): include review changes * fix(instance-create): linter fixes * move iframe usage to solution scenarios configurations * Revert "move iframe usage to solution scenarios configurations" This reverts commit 9db31f3. * fix merge * fix: add review suggestions Co-authored-by: Livio Spring <livio.a@gmail.com> * fix: add review changes * fix: add review changes for default definitions * fix: add review changes for machinekey details * fix: add machinekey output when setup with machineuser * fix: add changes from review * fix instance converter for machine and allow overwriting of further machine fields Co-authored-by: Livio Spring <livio.a@gmail.com> * chore: api brainstorming non working WIP * cleanup in redocly styling * feat(console): add some well known links in app detail, add refresh token grant type in dev mode creation (#4826) * fix(console): add some well known links * [servicename]/v1 * add refresh token grant type to devmode creation * extend example * docs: add installation videos (#4858) * docs: fix h2c link * Update http2.mdx * testing youtube and knative * docs: video guides for installation * docs: switched to iframe * Update docs/docs/guides/deploy/compose.mdx Co-authored-by: Elio Bischof <eliobischof@gmail.com> * Update docs/docs/guides/deploy/knative.mdx Co-authored-by: Elio Bischof <eliobischof@gmail.com> * Update docs/docs/guides/deploy/macos.mdx Co-authored-by: Elio Bischof <eliobischof@gmail.com> * Update docs/docs/guides/deploy/linux.mdx Co-authored-by: Elio Bischof <eliobischof@gmail.com> Co-authored-by: Elio Bischof <eliobischof@gmail.com> * docs: Correct knative yaml (#4874) corrected number to string * draft * fix: ensure domain policy is read for the correct org (#4872) * wip * feat: enable iframe use (#4766) * feat: enable iframe use * cleanup * fix mocks * fix linting * docs: add iframe usage to solution scenarios configurations * improve api * feat(console): security policy * description * remove unnecessary line * disable input button and urls when not enabled * add image to docs Co-authored-by: Max Peintner <max@caos.ch> Co-authored-by: Fabi <38692350+hifabienne@users.noreply.github.com> * docs: use latest image instead of stable in docker-compose.yml (#4876) docs: use latest image for compose * fix: protect default and zitadel project org from remove (#4875) * fix(login): allow setting language on registered users (#4862) * fix: user language for notifications * fix(login): allow setting language on registered users Co-authored-by: Livio Spring <livio.a@gmail.com> * fix(console): rename class (#4880) fix: rename class * fix(console): edit email for initial users (#4776) fix: edit email for initial users Co-authored-by: Livio Spring <livio.a@gmail.com> * docs: install crdb chart separately (#4849) * docs: install crdb chart separately * Update kubernetes.mdx * Update kubernetes.mdx Co-authored-by: Florian Forster <florian@zitadel.com> * fix: push timeout (#4882) (#4885) * push with timeout * test: config for eventstore (cherry picked from commit b9156da) Co-authored-by: Silvan <silvan.reusser@gmail.com> * docs: remove docs links (#4890) * docs: add logout guide * Update proto/zitadel/system.proto Co-authored-by: Florian Forster <florian@zitadel.com> * remove external docs Co-authored-by: Florian Forster <florian@zitadel.com> Co-authored-by: Livio Spring <livio.a@gmail.com> * docs: setup with service account docs (#4877) * docs: add service account setup for kubernetes * docs: add service account setup for macos, linux and compose * docs: change image tag in compose * docs: move default user part of kubernetes * docs: add prompt none to playground (#4894) Co-authored-by: Max Peintner <max@caos.ch> Co-authored-by: mffap <mpa@zitadel.com> Co-authored-by: Livio Spring <livio.a@gmail.com> Co-authored-by: Stefan Benz <46600784+stebenz@users.noreply.github.com> Co-authored-by: Silvan <silvan.reusser@gmail.com> Co-authored-by: Christian Jakob <47860090+thesephirot@users.noreply.github.com> Co-authored-by: Elio Bischof <eliobischof@gmail.com> Co-authored-by: Fabi <38692350+hifabienne@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4487